Skip to content

gh-136507: Fix mimetypes CLI cannot handle multiple file parameters #136508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-136507: Fix mimetypes CLI cannot handle multiple file parameters #136508

wants to merge 4 commits into from
+18 −4

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Jul 10, 2025 •
edited by bedevere-app bot
Loading

@Wulian233 Wulian233 requested a review from a team as a code owner July 10, 2025 13:03
@bedevere-app bedevere-app bot mentioned this pull request Jul 10, 2025
Open
encukou
encukou reviewed Jul 10, 2025
View reviewed changes
@Wulian233
Copy link
Contributor Author

Wulian233 commented Jul 14, 2025 •
edited
Loading

Supplement: #136507 (comment) , so this only in 3.14 and 3.15.

CC: @hugovk could you review this?

@mpkocher
Copy link
Contributor

It's probably a good idea to add both success and failure test case for the multiple provided values (e.g., -e image/jpeg text/html, and -e image/jpeg text/xyz).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

@mpkocher mpkocher mpkocher left review comments

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wulian233 @mpkocher @encukou